From: Patrick McHardy <kaber@trash•net>
To: Herbert Xu <herbert@gondor•apana.org.au>
Cc: Andreas Unterluggauer <au@unterluggauer•org>, netdev@oss•sgi.com
Subject: Re: Fw: [Bugme-new] [Bug 4138] New: ipsec with racoon in transport mode with esp and ah hangs (problem is in xfrm_state_add)
Date: Tue, 08 Mar 2005 23:36:06 +0100 [thread overview]
Message-ID: <422E28D6.1070103@trash.net> (raw)
In-Reply-To: <20050131211102.GA20323@gondor.apana.org.au>
[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]
Herbert Xu wrote:
> Hi Andreas:
>
> On Mon, Jan 31, 2005 at 03:40:16PM +0000, Andreas Unterluggauer wrote:
>
>>2005-01-31 16:29:58: DEBUG: ===
>>2005-01-31 16:29:58: DEBUG: get pfkey ADD message
>>andi: libipsec/pfkey.c, pfkey_check: start (msg->sadb_msg_satype: 3)
>>2005-01-31 16:29:58: DEBUG: andi: in pfkey.c, pk_recvadd: msg->sadb_msg_seq 2, msg->sadb_msg_type: ADD
>>2005-01-31 16:29:58: INFO: IPsec-SA established: ESP/Transport 192.168.2.5->192.168.2.3 spi=103868257(0x630e761)
>>2005-01-31 16:29:58: DEBUG: ===
>
>
> Does the machine hang at this point in time? If not, then this is
> simply a racoon bug. Although the acquire message carries a policy
> with it, it's really only acquiring a single SA. Therefore, only
> the SA being acquired should be added with that sequence number.
You're right, but I think there is also kernel misbehaviour here that
is fixed by the patch for __xfrm_state_find_acq_byseq() I sent to Dave
earlier. Andreas, can you try this patch please ?
Regards
Patrick
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 420 bytes --]
===== net/xfrm/xfrm_state.c 1.55 vs edited =====
--- 1.55/net/xfrm/xfrm_state.c 2005-03-07 06:23:53 +01:00
+++ edited/net/xfrm/xfrm_state.c 2005-03-08 18:42:13 +01:00
@@ -609,7 +609,7 @@
for (i = 0; i < XFRM_DST_HSIZE; i++) {
list_for_each_entry(x, xfrm_state_bydst+i, bydst) {
- if (x->km.seq == seq) {
+ if (x->km.seq == seq && x->km.state == XFRM_STATE_ACQ) {
xfrm_state_hold(x);
return x;
}
next prev parent reply other threads:[~2005-03-08 22:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-31 6:44 Fw: [Bugme-new] [Bug 4138] New: ipsec with racoon in transport mode with esp and ah hangs (problem is in xfrm_state_add) Andrew Morton
2005-01-31 10:54 ` Herbert Xu
2005-01-31 15:19 ` Andreas Unterluggauer
2005-01-31 15:40 ` Andreas Unterluggauer
2005-01-31 21:11 ` Herbert Xu
2005-02-01 10:53 ` Andreas Unterluggauer
2005-03-08 22:36 ` Patrick McHardy [this message]
2005-03-08 23:00 ` Herbert Xu
2005-01-31 19:40 ` David S. Miller
2005-01-31 20:26 ` Herbert Xu
2005-01-31 20:36 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422E28D6.1070103@trash.net \
--to=kaber@trash$(echo .)net \
--cc=au@unterluggauer$(echo .)org \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=netdev@oss$(echo .)sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox