From: Jeff Garzik <jgarzik@pobox•com>
To: Jouni Malinen <jkmaline@cc•hut.fi>
Cc: netdev@oss•sgi.com
Subject: Re: [PATCH wireless-2.6 7/10] hostap: Rate limiting for debug messages
Date: Tue, 22 Mar 2005 18:11:52 -0500 [thread overview]
Message-ID: <4240A638.8090702@pobox.com> (raw)
In-Reply-To: <20050313003412.GH8253@jm.kir.nu>
Jouni Malinen wrote:
> Limit rate of debug messages for interrupts before card is ready. This
> could happen when multiple devices are sharing the same interrupt.
>
> Signed-off-by: Jouni Malinen <jkmaline@cc•hut.fi>
>
> Index: jm-wireless-2.6/drivers/net/wireless/hostap/hostap_hw.c
> ===================================================================
> --- jm-wireless-2.6.orig/drivers/net/wireless/hostap/hostap_hw.c 2005-03-12 16:10:40.000000000 -0800
> +++ jm-wireless-2.6/drivers/net/wireless/hostap/hostap_hw.c 2005-03-12 16:10:58.000000000 -0800
> @@ -2790,8 +2790,10 @@
> prism2_io_debug_add(dev, PRISM2_IO_DEBUG_CMD_INTERRUPT, 0, 0);
>
> if (local->func->card_present && !local->func->card_present(local)) {
> - printk(KERN_DEBUG "%s: Interrupt, but dev not OK\n",
> - dev->name);
> + if (net_ratelimit()) {
> + printk(KERN_DEBUG "%s: Interrupt, but dev not OK\n",
> + dev->name);
> + }
> return IRQ_HANDLED;
Patch is OK, but it highlights a bug:
You should return IRQ_NONE if the interrupt is not intended for your
hardware.
Jeff
next prev parent reply other threads:[~2005-03-22 23:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-13 0:17 [PATCH wireless-2.6 0/10] hostap: Updates from Host AP repository Jouni Malinen
2005-03-13 0:28 ` [PATCH wireless-2.6 1/10] hostap: Clear station statistic on accounting start Jouni Malinen
2005-03-13 0:29 ` [PATCH wireless-2.6 2/10] hostap: Include asm/io.h Jouni Malinen
2005-03-22 23:13 ` Jeff Garzik
2005-03-13 0:30 ` [PATCH wireless-2.6 3/10] hostap: Disable interrupts before Genesis mode Jouni Malinen
2005-03-13 0:31 ` [PATCH wireless-2.6 4/10] hostap: Add support for multi-func SanDisk ConnectPlus Jouni Malinen
2005-03-13 0:32 ` [PATCH wireless-2.6 5/10] hostap: Fix procfs rmdir after ifname change Jouni Malinen
2005-03-13 0:32 ` [PATCH wireless-2.6 6/10] hostap: Clear station statistic on accounting start Jouni Malinen
2005-03-13 0:34 ` [PATCH wireless-2.6 7/10] hostap: Rate limiting for debug messages Jouni Malinen
2005-03-22 23:11 ` Jeff Garzik [this message]
2005-03-25 2:46 ` Jouni Malinen
2005-03-25 3:54 ` Jeff Garzik
2005-03-13 0:34 ` [PATCH wireless-2.6 8/10] hostap: Improved suspend Jouni Malinen
2005-03-13 0:35 ` [PATCH wireless-2.6 9/10] hostap: Filter disconnect events Jouni Malinen
2005-03-13 0:41 ` [PATCH wireless-2.6 10/10] hostap: Update to use the new WE18 proposal Jouni Malinen
2005-03-22 23:11 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4240A638.8090702@pobox.com \
--to=jgarzik@pobox$(echo .)com \
--cc=jkmaline@cc$(echo .)hut.fi \
--cc=netdev@oss$(echo .)sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox