From: Jeff Garzik <jgarzik@pobox•com>
To: Michael Chan <mchan@broadcom•com>
Cc: "David S. Miller" <davem@davemloft•net>, netdev@oss•sgi.com
Subject: Re: [PATCH 2.6.11 3/8] tg3: Add msi support for 5750 C0
Date: Tue, 22 Mar 2005 19:28:41 -0500 [thread overview]
Message-ID: <4240B839.6090604@pobox.com> (raw)
In-Reply-To: <B1508D50A0692F42B217C22C02D84972020F3E31@NT-IRVA-0741.brcm.ad.broadcom.com>
Michael Chan wrote:
> "Jeff Garzik" wrote:
>
>
>>I would prefer that a new 'static inline' function was created,
>>containing the core interrupt handler code.
>>
>>This avoids the code duplication you have in this patch, in
>>new function
>>tg3_msi().
>>
>> Jeff
>>
>
>
> There are enough subtle differences between tg3_interrupt() and tg3_msi()
> that makes it impractical to create a core inline function to be shared by
> the two. To share a meaningful chunk of the code, it will have to check for
> MSI mode and skip some of the register reads. The reason I created tg3_msi()
> was to avoid all conditionals.
After reviewing the existing tg3.c code again, I agree. Objection
withdrawn.
Jeff
next prev parent reply other threads:[~2005-03-23 0:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-23 0:24 [PATCH 2.6.11 3/8] tg3: Add msi support for 5750 C0 Michael Chan
2005-03-23 0:28 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-03-21 7:34 Michael Chan
2005-03-22 20:56 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4240B839.6090604@pobox.com \
--to=jgarzik@pobox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=mchan@broadcom$(echo .)com \
--cc=netdev@oss$(echo .)sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox