Subject: Re: [PATCH] forcedeth: Add support for 64-bit dma addresses.

From: Jeff Garzik <[email-masked]>
Date: Fri, 22 Jul 2005 16:56:35 -0400

Manfred Spraul wrote:
> +	if (id->driver_data & DEV_HAS_HIGH_DMA) {
> +		np->desc_ver = DESC_VER_3;
> +		dev->features |= NETIF_F_HIGHDMA;
> +		if (pci_set_dma_mask(pci_dev, 0x0000007fffffffffULL)) {
> +			if (pci_set_dma_mask(pci_dev, 0xffffffffULL))
> +				goto out_relreg;
> +		}

setting of NETIF_F_HIGHDMA is wrong, if 64-bit set-dma-mask fails.