Subject: Re: [PATCH (resent with the attachment !)] netfilter : zap get_cpu()/put_cpu() calls from ip_tables

From: Patrick McHardy <[email-masked]>
Date: Fri, 25 Nov 2005 19:20:42 +0100

Eric Dumazet wrote:
> The 'ip_tables: NUMA-aware allocation' patch 
> (http://www.kernel.org/git/?p=linux/kernel/git/davem/net-2.6.16.git;a=commit;h=6d1273850cac8db77c462caaa145b813d93adc55) 
> 
> introduced a problem with get_cpu()/put_cpu()
> 
> The problem is that get_cpu() disables preemption and the thread is not 
> allowed to sleep.
> 
> As the intent was only to give a hint, relax the enforcement and switch 
> to a hint : If the current thread is preempted and migrated to another 
> cpu, this is not a problem. Most of the time, thread wont be migrated 
> anyway.
> 
> This patch removes get_cpu()/put_cpu() pairs and uses 
> raw_smp_processor_id() were appropriate.

Looks good, thanks. I'm going to test it and pass it on to Dave if it
works.