Subject: Re: [PATCH] powerpc: ibmveth: Harden driver initilisation for kexec

From: Jeff Garzik <[email-masked]>
Date: Thu, 02 Mar 2006 20:04:39 -0500

Santiago Leon wrote:
> From: Michael Ellerman <[email-masked]>
> 
> After a kexec the veth driver will fail when trying to register with the
> Hypervisor because the previous kernel has not unregistered.
> 
> So if the registration fails, we unregister and then try again.
> 
> Signed-off-by: Michael Ellerman <[email-masked]>
> Acked-by: Anton Blanchard <[email-masked]>
> Signed-off-by: Santiago Leon <[email-masked]>
> ---
> 
>  drivers/net/ibmveth.c |   32 ++++++++++++++++++++++++++------
>  1 files changed, 26 insertions(+), 6 deletions(-)
> 
> Looks good to me, and has been around for a couple of months.

This seems completely bonkers to me:

	are resources available?
	if no
		free resources
		try again

It makes resource checking pointless.

	Jeff