Subject: Re: [e1000 debug] KERNEL: assertion (!sk_forward_alloc) failed...

From: "Boris B. Zhmurov" <[email-masked]>
Date: Thu, 30 Mar 2006 14:02:01 +0400

Hello, Herbert Xu.

On 30.03.2006 13:52 you said the following:

> On Wed, Mar 29, 2006 at 08:44:09PM -0800, David S. Miller wrote:
> 
>>Herbert do you see any holes here?
> 
> 
> Well I started from the beginning again, and found this.  This may be
> the smoking gun that we're after :)
> 
> The xmit routine is lockless but checks last_tx_tso outside the locked
> section.  So if a TSO packet wins a race against a non-TSO packet with
> last_tx_tso == 0 then we'll have memory corruption.
> 
> Everyone, please try this patch and let us know whether the problem
> goes away.
> 
> Thanks,

[zhmurov@builds linux-2.6.16]$ patch -p1 < 
../../../SOURCES/linux-2.6.16-e1000-try-to-fix-assertion_sk_forward_alloc_failed_by_Herbert_Xu.patch 

patching file drivers/net/e1000/e1000_main.c
Reversed (or previously applied) patch detected!  Assume -R? [n]

Herbert, is that patch already included in 2.6.16.1?

-- 
Boris B. Zhmurov
mailto: [email-masked]
"wget http://kernelpanic.ru/bb_public_key.pgp -O - | gpg --import"

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642