From: Shailabh Nagar <nagar@watson•ibm.com>
To: balbir@in•ibm.com
Cc: Andrew Morton <akpm@osdl•org>,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
tgraf@suug•ch, hadi@cyberus•ca
Subject: Re: [Patch 5/8] generic netlink interface for delay accounting
Date: Thu, 30 Mar 2006 11:24:38 -0500 [thread overview]
Message-ID: <442C0646.3090308@watson.ibm.com> (raw)
In-Reply-To: <20060330061005.GA18387@in.ibm.com>
Balbir Singh wrote:
>Hi, Andrew
>
>
>On Wed, Mar 29, 2006 at 09:04:06PM -0800, Andrew Morton wrote:
>
>
>>Shailabh Nagar <nagar@watson•ibm.com> wrote:
>>
>>
>>>delayacct-genetlink.patch
>>>
>>>Create a generic netlink interface (NETLINK_GENERIC family),
>>>called "taskstats", for getting delay and cpu statistics of
>>>tasks and thread groups during their lifetime and when they exit.
>>>
>>>
>>>
>>>
>>>
<snip>
>>>+
>>>+static int __init taskstats_init(void)
>>>+{
>>>+ if (genl_register_family(&family))
>>>+ return -EFAULT;
>>>
>>>
>>EFAULT?
>>
>>
>
>It shouldn't be (Shailabh please comment). We will fix it.
>
>
Sorry, it should return the value returned by genl_register_family.
I copied the code from net/tipc/netlink.c
where a similarly erroneous errno is being used. We'll submit a fix
for that as well.
--Shailabh
prev parent reply other threads:[~2006-03-30 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <442B271D.10208@watson.ibm.com>
2006-03-30 0:48 ` [Patch 4/8] generic netlink utility functions Shailabh Nagar
2006-03-30 0:52 ` [Patch 5/8] generic netlink interface for delay accounting Shailabh Nagar
2006-03-30 5:04 ` Andrew Morton
2006-03-30 6:10 ` Balbir Singh
2006-03-30 6:26 ` Andrew Morton
2006-03-30 6:29 ` Balbir Singh
2006-03-30 16:24 ` Shailabh Nagar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442C0646.3090308@watson.ibm.com \
--to=nagar@watson$(echo .)ibm.com \
--cc=akpm@osdl$(echo .)org \
--cc=balbir@in$(echo .)ibm.com \
--cc=hadi@cyberus$(echo .)ca \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox