Subject: Re: [patch 8/9] forcedeth: suggested cleanups

From: Jeff Garzik <[email-masked]>
Date: Thu, 27 Apr 2006 05:56:49 -0400

[email-masked] wrote:
> From: Ingo Oeser <[email-masked]>
> 
> general:
> 	- endian annotation of the ring descriptors
> 
> nv_getlen():
> 	- use htons() instead of __constant_htons()
>           to improvde readability and let the compiler constant fold it.
> 
> nv_rx_process():
> 	- use a real for() loop in processing instead of goto and break
> 	- consolidate rx_errors increment
> 	- count detected rx_length_errors
> 
> Signed-off-by: Ingo Oeser <[email-masked]>
> Cc: Manfred Spraul <[email-masked]>
> Signed-off-by: Andrew Morton <[email-masked]>

ACK, but I'm holding off applying this while trying to get 4 apply-able 
patches out of NVIDIA and Manfred :)

	Jeff