From: Michal Schmidt <xschmi00@stud•feec.vutbr.cz>
To: Dan Williams <dcbw@redhat•com>
Cc: netdev@vger•kernel.org,
"John W. Linville" <linville@tuxdriver•com>,
matthieu castet <castet.matthieu@free•fr>,
Javier Achirica <achirica@telefonica•net>,
Jean Tourrilhes <jt@hpl•hp.com>
Subject: Re: [PATCH] wireless/airo: minimal WPA awareness
Date: Tue, 02 May 2006 23:29:55 +0200 [thread overview]
Message-ID: <4457CF53.7050000@stud.feec.vutbr.cz> (raw)
In-Reply-To: <1145118379.2324.18.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 937 bytes --]
Dan Williams wrote:
> airo cards with firmware versions of 5.30.17 and higher support WPA.
> This patch recognizes WPA-capable firmware versions and adds support for
> retrieving the WPA and RSN information elements from the card's scan
> results. The JOB and FLAG fields are now independent, since there was
> no space left in the FLAG field for FLAG_WPA_CAPABLE.
>
> Signed-off-by: matthieu castet <castet.matthieu@free•fr>
> Signed-off-by: Dan Williams <dcbw@redhat•com>
Running Linux 2.6.17-rc3-mm1 which has this patch included I get this
interesting message:
airo(eth0): WPA unsupported (only firmware versions 5.30.17 and greater
support WPA. Detected 5.30.17)
airo_test_wpa_capable assumes that the softSubVer part of the firmware
version number is coded in BCD. Apparently, that's not true.
I have firmware version 5.30.17 and cap_rid.softSubVer is 0x11==17.
Signed-off-by: Michal Schmidt <xschmi00@stud•feec.vutbr.cz>
[-- Attachment #2: airo-fix-firmware-version-compare.diff --]
[-- Type: text/plain, Size: 641 bytes --]
diff -Nurp -X linux-mich/Documentation/dontdiff linux-mm/drivers/net/wireless/airo.c linux-mich/drivers/net/wireless/airo.c
--- linux-mm/drivers/net/wireless/airo.c 2006-05-02 20:20:37.000000000 +0200
+++ linux-mich/drivers/net/wireless/airo.c 2006-05-02 23:16:59.000000000 +0200
@@ -2768,7 +2768,7 @@ static int airo_test_wpa_capable(struct
/* Only firmware versions 5.30.17 or better can do WPA */
if ((cap_rid.softVer > 0x530)
- || ((cap_rid.softVer == 0x530) && (cap_rid.softSubVer >= 0x17))) {
+ || ((cap_rid.softVer == 0x530) && (cap_rid.softSubVer >= 17))) {
airo_print_info(name, "WPA is supported.");
return 1;
}
next prev parent reply other threads:[~2006-05-02 21:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-15 16:26 [PATCH] wireless/airo: minimal WPA awareness Dan Williams
2006-05-02 21:29 ` Michal Schmidt [this message]
2006-05-02 22:53 ` VJ Channel API - driver level (README) Alex Aizman
2006-05-03 6:49 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4457CF53.7050000@stud.feec.vutbr.cz \
--to=xschmi00@stud$(echo .)feec.vutbr.cz \
--cc=achirica@telefonica$(echo .)net \
--cc=castet.matthieu@free$(echo .)fr \
--cc=dcbw@redhat$(echo .)com \
--cc=jt@hpl$(echo .)hp.com \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox