Subject: Re: [resend PATCH 1/1] b44: fix ethool link settings support

From: Jeff Garzik <[email-masked]>
Date: Wed, 24 May 2006 02:41:18 -0400

Gary Zambrano wrote:
> +		if (cmd->advertising & ADVERTISE_ALL) {
> +			if (cmd->advertising & ADVERTISE_10HALF)
> +				bp->flags |= B44_FLAG_ADV_10HALF;
> +			if (cmd->advertising & ADVERTISE_10FULL)
> +				bp->flags |= B44_FLAG_ADV_10FULL;
> +			if (cmd->advertising & ADVERTISE_100HALF)
> +				bp->flags |= B44_FLAG_ADV_100HALF;
> +			if (cmd->advertising & ADVERTISE_100FULL)
> +				bp->flags |= B44_FLAG_ADV_100FULL;
> +		} else {
> +			bp->flags |= (B44_FLAG_ADV_10HALF |
> +				      B44_FLAG_ADV_10FULL |
> +				      B44_FLAG_ADV_100HALF |
> +				      B44_FLAG_ADV_100FULL);
> +		}

The logic above is backwards.  I presume the first test should be
	if (!(cmd->advertising & ADVERTISE_ALL))

The rest looks OK.

	Jeff