Subject: Re: [PATCH] ip_conntrack_helper_pptp.c: fix sstate/cstate typo

From: Patrick McHardy <[email-masked]>
Date: Fri, 26 May 2006 16:38:43 +0200

Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <[email-masked]>
> ---
> 
> --- a/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
> +++ b/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
> @@ -469,8 +469,8 @@ pptp_inbound_pkt(struct sk_buff **pskb,
>  			DEBUGP("%s but no session\n", pptp_msg_name[msg]);
>  			break;
>  		}
> -		if (info->sstate != PPTP_CALL_IN_REP
> -		    && info->sstate != PPTP_CALL_IN_CONF) {
> +		if (info->cstate != PPTP_CALL_IN_REP
> +		    && info->cstate != PPTP_CALL_IN_CONF) {
>  			DEBUGP("%s but never sent IN_CALL_REPLY\n",
>  				pptp_msg_name[msg]);
>  			break;

Looks correct to me, but I'm not that familiar with the code.
Harald, do you want me to apply this?