Subject: Re: [PATCH 2/2] PHYLIB/gianfar: Use phy_ethtool_get_link() for get_link op

From: Jeff Garzik <[email-masked]>
Date: Thu, 08 Jun 2006 11:33:55 -0400

Nathaniel Case wrote:
> On Thu, 2006-06-08 at 10:58 -0400, Jeff Garzik wrote:
>>> +static u32 gfar_get_link(struct net_device *dev)
>>> +{
>>> +	struct gfar_private *priv = netdev_priv(dev);
>>> +	struct phy_device *phydev = priv->phydev;
>>> +
>>> +	if (NULL == phydev)
>>> +		return -ENODEV;
>> NAK, return code obviously wrong
> 
> Thanks.  I think we can just return 0 for that case.  Updated patch
> follows.
> 
> Signed-off-by: Nate Case <[email-masked]>

Sigh.  See rule #6: http://linux.yyz.us/patch-format.html

You excised the patch description, which means your patch can no longer 
be applied correctly by scripts.

	Jeff