Subject: Re: [patch 6/8] drivers/char/hw_random.c: remove assert()'s

From: Jeff Garzik <[email-masked]>
Date: Fri, 09 Jun 2006 10:19:35 -0400

[email-masked] wrote:
> From: Adrian Bunk <[email-masked]>
> 
> Remove the assert()'s from drivers/char/hw_random.c since you both needed
> to enable a manual option in the driver source to make them effective and
> they only covered some obviously impossible cases.
> 
> Signed-off-by: Adrian Bunk <[email-masked]>
> Signed-off-by: Andrew Morton <[email-masked]>

100% NAK.  They are there, obviously, for driver debugging and 
development.  Just like libata's debug stuff, you certainly have to 
enable them manually.

Until this driver goes away (real soon, right?), the debugging facility 
should stay.

	Jeff