From: David Ahern <dsahern@gmail•com>
To: Ido Schimmel <idosch@idosch•org>
Cc: netdev@vger•kernel.org, davem@davemloft•net,
roopa@cumulusnetworks•com, nikolay@cumulusnetworks•com,
tom@herbertland•com
Subject: Re: [PATCH v2 net-next 01/10] net/ipv4: Pass net to fib_multipath_hash instead of fib_info
Date: Fri, 2 Mar 2018 08:28:52 -0700 [thread overview]
Message-ID: <449645ff-adbe-a40c-e89f-6930cd1454ae@gmail.com> (raw)
In-Reply-To: <20180302131259.GA23979@splinter>
On 3/2/18 6:12 AM, Ido Schimmel wrote:
> On Thu, Mar 01, 2018 at 07:29:41PM -0800, David Ahern wrote:
>> fib_multipath_hash only needs net struct to check a sysctl. Make it
>> clear by passing net instead of fib_info. In the need this allows
>> alignment between the ipv4 and ipv6 versions.
>>
>> Signed-off-by: David Ahern <dsahern@gmail•com>
>> ---
>> include/net/ip_fib.h | 5 +++--
>> net/ipv4/fib_semantics.c | 2 +-
>> net/ipv4/route.c | 9 +++++----
>> 3 files changed, 9 insertions(+), 7 deletions(-)
>>
>> diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
>> index 8812582a94d5..1c4219e88726 100644
>> --- a/include/net/ip_fib.h
>> +++ b/include/net/ip_fib.h
>> @@ -395,8 +395,9 @@ int fib_sync_down_addr(struct net_device *dev, __be32 local);
>> int fib_sync_up(struct net_device *dev, unsigned int nh_flags);
>>
>> #ifdef CONFIG_IP_ROUTE_MULTIPATH
>> -int fib_multipath_hash(const struct fib_info *fi, const struct flowi4 *fl4,
>> - const struct sk_buff *skb, struct flow_keys *flkeys);
>> +int fib_multipath_hash(const struct net *net, const struct fib_info *fi,
>> + const struct flowi4 *fl4, const struct sk_buff *skb,
>> + struct flow_keys *flkeys);
>
> Why did you keep the fib info?
>
ugh. The whole point of this patch is to drop it. Must have been
distracted rebasing it to top of tree.
next prev parent reply other threads:[~2018-03-02 15:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 3:29 [PATCH v2 net-next 00/10] net/ipv6: Add support for path selection using hash of 5-tuple David Ahern
2018-03-02 3:29 ` [PATCH v2 net-next 01/10] net/ipv4: Pass net to fib_multipath_hash instead of fib_info David Ahern
2018-03-02 13:12 ` Ido Schimmel
2018-03-02 15:28 ` David Ahern [this message]
2018-03-02 3:29 ` [PATCH v2 net-next 02/10] net: Align ip_multipath_l3_keys and ip6_multipath_l3_keys David Ahern
2018-03-02 13:22 ` Ido Schimmel
2018-03-02 3:29 ` [PATCH v2 net-next 03/10] net/ipv4: Simplify fib_multipath_hash with optional flow keys David Ahern
2018-03-02 13:26 ` Ido Schimmel
2018-03-02 3:29 ` [PATCH v2 net-next 04/10] net/ipv6: Make rt6_multipath_hash similar to fib_multipath_hash David Ahern
2018-03-02 13:35 ` Ido Schimmel
2018-03-02 3:29 ` [PATCH v2 net-next 05/10] net: Rename NETEVENT_MULTIPATH_HASH_UPDATE David Ahern
2018-03-02 13:36 ` Ido Schimmel
2018-03-02 3:29 ` [PATCH v2 net-next 06/10] net/ipv6: Pass skb to route lookup David Ahern
2018-03-02 13:49 ` Ido Schimmel
2018-03-02 3:29 ` [PATCH v2 net-next 07/10] net/ipv6: Add support for path selection using hash of 5-tuple David Ahern
2018-03-02 13:52 ` Ido Schimmel
2018-03-02 3:29 ` [PATCH v2 net-next 08/10] mlxsw: spectrum_router: Add support for ipv6 hash policy update David Ahern
2018-03-02 14:02 ` Ido Schimmel
2018-03-02 15:33 ` David Ahern
2018-03-02 3:29 ` [PATCH v2 net-next 09/10] net: Remove unused get_hash_from_flow functions David Ahern
2018-03-02 14:09 ` Ido Schimmel
2018-03-02 15:33 ` David Ahern
2018-03-02 3:29 ` [PATCH v2 net-next 10/10] selftests: forwarding: Add multipath test for L4 hashing David Ahern
2018-03-02 14:10 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449645ff-adbe-a40c-e89f-6930cd1454ae@gmail.com \
--to=dsahern@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=idosch@idosch$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@cumulusnetworks$(echo .)com \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=tom@herbertland$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox