Subject: Re: Memory corruption in 8390.c ? (was Re: Possible leaks in network drivers)

From: Jeff Garzik <[email-masked]>
Date: Thu, 22 Jun 2006 04:22:22 -0400

Herbert Xu wrote:
> This patch uses pskb_expand_head to expand the existing skb and linearize

Seems sane to me.

> it if needed.  Actually, someone should sift through every instance of
> skb_pad on a non-linear skb as they do not fit the reasons why this was
> originally created.

Non-linear skbs smaller than ETH_ZLEN seem unlikely.

Overall, the skb_pad() changes were made over a short span of time, 
often to older and under-used drivers, so I would not be surprised to 
find rough edges or the occasional bug.

	Jeff