Subject: Kernel Janitor TODO: dev_kfree_skb

From: John Daiker <[email-masked]>
Date: Fri, 23 Jun 2006 10:35:53 -0700

I was running through the kernel janitors TODO list 
(http://janitor.kernelnewbies.org/TODO) and thought I'd try to find 
something easy for my first attempt at kernel hacking/maintenance.

The "Balancing Function" header suggests that all net_device interrupt 
functions should use dev_kfree_skb_irq as opposed to dev_kfree_skb.
Should we ever be calling dev_kfree_skb directly, or would the better 
practice be to always call dev_kfree_skb_any (thus letting the kernel 
decide to call dev_kfree_skb or dev_kfree_skb_irq)?

dev_kfree_skb_any is defined in 'net/core/dev.c:1118'

John Daiker