Subject: Re: [PATCH 02/21] e1000: rework driver hardware reset locking

From: Auke Kok <[email-masked]>
Date: Tue, 27 Jun 2006 07:42:59 -0700

Jeff Garzik wrote:
> Kok, Auke wrote:
>> @@ -631,6 +627,9 @@ e1000_set_ringparam(struct net_device *n
>>      tx_ring_size = sizeof(struct e1000_tx_ring) * 
>> adapter->num_tx_queues;
>>      rx_ring_size = sizeof(struct e1000_rx_ring) * 
>> adapter->num_rx_queues;
>>  
>> +    while (test_and_set_bit(__E1000_RESETTING, &adapter->flags))
>> +        msleep(1);
> 
> This is a bit worrying, but no outright objection.  We don't want to see 
> these accumulate.

Agreed but at least we removed the opportunity to panic the driver as easy as 
with 2 commandline commands (in several ways) - we're still looking into 
improving this - any comments would be appreciated.

Cheers,

Auke