From: Patrick McHardy <kaber@trash•net>
To: Stefan Rompf <stefan@loplof•de>
Cc: Linux Netdev List <netdev@vger•kernel.org>,
Ben Greear <greearb@candelatech•com>
Subject: Re: [VLAN]: translate IF_OPER_DORMANT to netif_dormant_on()
Date: Wed, 05 Jul 2006 23:00:07 +0200 [thread overview]
Message-ID: <44AC2857.5030706@trash.net> (raw)
In-Reply-To: <200607052057.05526.stefan@loplof.de>
Stefan Rompf wrote:
> Am Dienstag 04 Juli 2006 12:07 schrieb Patrick McHardy:
>
>
>>>- new_dev->state = real_dev->state & VLAN_LINK_STATE_MASK;
>>>+ new_dev->state = real_dev->state & ~(1<<__LINK_STATE_START);
>
>
>>This introduced a regression by propagating the __LINK_STATE_XOFF flag,
>>when the queue of the underlying device is stopped it will be stopped
>>for the VLAN device too and never be woken up. Since you changed
>>VLAN_LINK_STATE_MASK, I assume the intention was to just add
>>__LINK_STATE_DORMANT to the propagated flags and keep using it here?
>
>
> Hm, I did not hit that bug during tests, even though starfire calls
> netif_stop_queue() on close. But I don't remember whether I tested added
> VLANs while the main interface was ifconfig'ed down.
It hits me whenever I boot with sky2, it seems to need a while before
a carrier is detected.
> Anyway, is it good to propagate __LINK_STATE_PRESENT then? The same situation
> here, add a VLAN while the main interface is "not present", and you are out.
> Can you try to revert the quoted part of my patch, I'll rethink which flags
> should be copied on device creation.
I tried both adding LINK_STATE_XOFF to the negated flags and using
VLAN_LINK_STATE_MASK, both as expected solve the problem for me.
I have to admit I was wondering about LINK_STATE_PRESENT as well
(was going to complain about that too until I noticed it is also
set in VLAN_LINK_STATE_MASK). Maybe Ben can tell us the idea behind
this?
next prev parent reply other threads:[~2006-07-05 21:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200603211829.k2LITMNR029085@hera.kernel.org>
2006-07-04 10:07 ` [VLAN]: translate IF_OPER_DORMANT to netif_dormant_on() Patrick McHardy
2006-07-05 18:57 ` Stefan Rompf
2006-07-05 21:00 ` Patrick McHardy [this message]
2006-07-05 21:17 ` Ben Greear
2006-07-06 7:42 ` Patrick McHardy
2006-07-07 9:45 ` Stefan Rompf
2006-07-07 9:56 ` Patrick McHardy
2006-07-07 21:33 ` Stephen Hemminger
2006-07-09 8:49 ` Stefan Rompf
2006-07-09 18:48 ` David Miller
2006-07-09 20:05 ` Krzysztof Halasa
2006-07-10 0:29 ` David Miller
2006-07-10 11:39 ` Krzysztof Halasa
2006-07-10 6:17 ` Stefan Rompf
2006-07-10 12:01 ` Krzysztof Halasa
2006-07-10 21:58 ` Stefan Rompf
2006-07-10 16:56 ` Stephen Hemminger
2006-07-10 17:02 ` Ben Greear
2006-07-10 22:01 ` Stefan Rompf
2006-07-11 21:28 ` [RFC] vlan handling of up/down Stephen Hemminger
2006-07-11 21:47 ` Ben Greear
2006-07-11 22:19 ` Stefan Rompf
2006-07-11 22:07 ` [VLAN]: translate IF_OPER_DORMANT to netif_dormant_on() Stefan Rompf
2006-07-11 22:15 ` Repost: " Stefan Rompf
2006-07-12 6:50 ` Patrick McHardy
2006-07-19 12:42 ` Patrick McHardy
2006-07-24 20:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44AC2857.5030706@trash.net \
--to=kaber@trash$(echo .)net \
--cc=greearb@candelatech$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stefan@loplof$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox