Subject: Re: [patch 8/9] smsc-ircc2: fix section reference mismatches

From: Jeff Garzik <[email-masked]>
Date: Fri, 07 Jul 2006 13:28:16 -0400

[email-masked] wrote:
> From: Dmitry Torokhov <[email-masked]>
> 
> subsystem_configurations array is only used by an __init function,
> therefore it should be marked __initdata, not __devinitdata.
> 
> Signed-off-by: Dmitry Torokhov <[email-masked]>
> Signed-off-by: Andrew Morton <[email-masked]>
> ---
> 
>  drivers/net/irda/smsc-ircc2.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/net/irda/smsc-ircc2.c~smsc-ircc2-fix-section-reference-mismatches drivers/net/irda/smsc-ircc2.c
> --- a/drivers/net/irda/smsc-ircc2.c~smsc-ircc2-fix-section-reference-mismatches
> +++ a/drivers/net/irda/smsc-ircc2.c
> @@ -2353,7 +2353,7 @@ static int __init smsc_superio_lpc(unsig
>  #ifdef CONFIG_PCI
>  #define PCIID_VENDOR_INTEL 0x8086
>  #define PCIID_VENDOR_ALI 0x10b9
> -static struct smsc_ircc_subsystem_configuration subsystem_configurations[] __devinitdata = {
> +static struct smsc_ircc_subsystem_configuration subsystem_configurations[] __initdata = {

Are you sure this fully solves the problem?

It seems like the functions referenced inside this are inappropriately 
marked as well...