Subject: Re: [RESEND 3/5] [NET]: Protocol Independant Policy Routing Rules Framework

From: Patrick McHardy <[email-masked]>
Date: Mon, 31 Jul 2006 20:01:56 +0200

Thomas Graf wrote:
> * Ville Nuorvala <[email-masked]> 2006-07-31 17:46
>
>>Shouldn't all these (struct fib_rule_hdr included) actually be defined
>>in include/linux/rtnetlink.h?
> 
> 
> We used to stuff everything into rtnetlink.h for no good reason. Having
> independant include/linux/<subsystem>.h to export the interface to
> userspace and include/net/<subsystem>.h to export the kernel interface
> instead of contributing to the ifdef hell seems a lot cleaner to me.

I agree, but then we should also split up rtnetlink.h. Having one
special case will just make it harder to find.