Subject: Re: [PATCH 22/23] [PATCH] [XFRM] POLICY: Support netlink socket interface for sub policy.

From: Masahide NAKAMURA <[email-masked]>
Date: Wed, 02 Aug 2006 10:46:50 +0900

David Miller wrote:
> From: Masahide NAKAMURA <[email-masked]>
> Date: Sat, 29 Jul 2006 18:30:55 +0900
> 
>> diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h
>> index 901bb65..68d3443 100644
>> --- a/include/linux/xfrm.h
>> +++ b/include/linux/xfrm.h
>> @@ -303,12 +303,14 @@ #define XFRM_POLICY_BLOCK	1
>>  	__u8				flags;
>>  #define XFRM_POLICY_LOCALOK	1	/* Allow user to override global policy */
>>  	__u8				share;
>> +	__u8				type;
>>  };
>>  
>>  struct xfrm_userpolicy_id {
>>  	struct xfrm_selector		sel;
>>  	__u32				index;
>>  	__u8				dir;
>> +	__u8				type;
>>  };
>>  
>>  struct xfrm_user_acquire {
> 
> Again, these are user visible data structures which cannot be
> modified without changing the API.  Please use another xfrm
> netlink attribute or similar to pass this information.

I'll try to add XFRMA_POLICY_TYPE for this case.
Thanks,

-- 
Masahide NAKAMURA