Subject: Re: [take5 1/4] kevent: Core files.

From: Zach Brown <[email-masked]>
Date: Tue, 08 Aug 2006 15:02:59 -0700

> +++ b/include/linux/kevent.h

 ...

> +#ifdef CONFIG_KEVENT_SOCKET
> +
> +extern struct file_operations socket_file_ops;

This doesn't build because socket_file_ops was left static in net/socket.c.

In any case, kevent.h has no business exposing socket_file_ops to users
of the kevent api just so the kevent core can test files as being backed
by sockets.  It'd be more appropriate to call into the socket layer with
the filp and let it return -EINVAL or -ESOCKNOOPT instead of trying to
do that in the kevent layer.

- z