Subject: Re: [PATCH 1/9] [TULIP] Fix PHY init and reset

From: Jeff Garzik <[email-masked]>
Date: Wed, 09 Aug 2006 01:29:33 -0400

Kyle McMartin wrote:
> From: Grant Grundler <[email-masked]>
> 
> A whole slew of fixes for tulip_select_media for:
>  - Flush posted MMIO writes as per PCI spec
>  - Polling the reset bit (bit 15) is required to determine when
>    the "init" sequence can be sent.
> 
> This fixes tulip on HP PA-RISC systems, which use DP83840A and
> LXT971D PHYs. Tested for several years on a variety of HP PA-RISC
> systems.
> 
> [Initial work done by Grant Grundler, DS21142 support added by
> Thibaut Varene.]
> 
> Signed-off-by: Grant Grundler <[email-masked]>
> Signed-off-by: Thibaut Varene <[email-masked]>
> Signed-off-by: Kyle McMartin <[email-masked]>

seems OK except for two details:

* [old news]  the delays should turn into sleeps, once Francois's patch 
is applied
* seems like you should be using get_u16() etc. for possibly-unaligned data