Subject: Re: [PATCH] cleanup of the NETIF_F_* flag definitions

From: Jeff Garzik <[email-masked]>
Date: Sat, 12 Aug 2006 15:37:32 -0400

Peter Zijlstra wrote:
> Cleanup the NETIF_F_ flag definitions
> 
> Signed-off-by: Peter Zijlstra <[email-masked]>

If you are going to do a cleanup here, you should use the form that 
makes it _immediately_ obvious which bit(s) are being used:

#define NETIF_F_SG	(1 << 0)
#define NETIF_F_IP_CSUM	(1 << 1)
#define NETIF_F_NO_CSUM	(1 << 2)
[...]

Maybe DaveM's brain automatically translates all hex numbers into bit 
numbers, but not everybody's brain works that way... :)  It is better to 
use a form that requires no human brain translation...

	Jeff