Subject: Re: [PATCH 2/3] myri10ge: allow to disable link status change reporting

From: Jeff Garzik <[email-masked]>
Date: Mon, 14 Aug 2006 18:02:30 -0400

Brice Goglin wrote:
> Add myri10ge_verbose module parameter to disable reporting of
> link status change since some Ethernet switches seem to generate
> a lot of status changes under some circumstances and some people
> want to avoid useless flooding in the logs.
> 
> Also add a counter for link status changes to statistics.
> 
> Signed-off-by: Brice Goglin <[email-masked]>

NAK - use the standard netif_msg_xxx and the msg_enable style variable 
found in many drivers.  No need for a module parameter, ethtool already 
covers this type of need.

	Jeff