Subject: Re: [PATCH 3/6] IP100A Remove CONFIG_SUNDANCE_MMIO, mask of mapping address

From: Jeff Garzik <[email-masked]>
Date: Thu, 17 Aug 2006 10:46:58 -0400

Jesse Huang wrote:
> -/* Work-around for Kendin chip bugs. */
> -#ifndef CONFIG_SUNDANCE_MMIO
> -#define USE_IO_OPS 1
> -#endif

Why?  This simply eliminates the ability of the user to set the driver 
configuration at Kconfig time, requiring them to edit the driver to 
achieve the same functionality.

> @@ -491,10 +487,13 @@ #endif
>  	if (pci_request_regions(pdev, DRV_NAME))
>  		goto err_out_netdev;
>  
> -	ioaddr = pci_iomap(pdev, bar, netdev_io_size);
> +	ioaddr =(void __iomem *)
> +		 ((unsigned long)pci_iomap(pdev, bar, netdev_io_size) & 
> +	          0xffffff80);

NAK, this is very wrong.  pci_iomap() returns a "cookie", which you are 
not allowed to modify in any way.

	Jeff