Subject: Re: [PATCH] b44: fix eeprom endianess issue

From: Jeff Garzik <[email-masked]>
Date: Wed, 23 Aug 2006 12:55:02 -0400

Michael Buesch wrote:
>> Please note that this test is only compile tested, as
>> I don't have a b44 device.

>> @@ -2055,7 +2055,7 @@
>>  	u16 *ptr = (u16 *) data;
>>  
>>  	for (i = 0; i < 128; i += 2)
>> -		ptr[i / 2] = readw(bp->regs + 4096 + i);
>> +		ptr[i / 2] = cpu_to_le16(readw(bp->regs + 4096 + i));
>>  

This looks a bit weird.  readw() swaps on big-endian already.

This patch swaps each word -again- on big-endian, even though the only 
user of the eeprom data is the get-invariants code that reads the MAC 
address and phy id.

	Jeff