Subject: Re: [PATCH 22/26] ixgb: Cache-align all TX components of the adapter struct.

From: Auke Kok <[email-masked]>
Date: Tue, 29 Aug 2006 15:20:44 -0700

Jeff Garzik wrote:
> Eric Dumazet wrote:
>> On Tuesday 29 August 2006 18:45, Kok, Auke wrote:
>>>      /* TX */
>>> -    struct ixgb_desc_ring tx_ring;
>>> +    struct ixgb_desc_ring tx_ring ____cacheline_aligned;
>>>      unsigned long timeo_start;
>>
>> On UP, this would only enlarge the size of structure and might consume 
>> more cache lines...
>>
>>  I guess ____cacheline_aligned_in_smp is preferred here.
>>
>> (see include/linux/netdevice.h)

changed in our tree to ____cacheline_aligned_in_smp.

Thanks,

Auke