Subject: Re: [PATCH]ethtool.c:fix buffer overflow when devname is too long

From: Jeff Garzik <[email-masked]>
Date: Wed, 30 Aug 2006 07:30:00 -0400

[email-masked] wrote:
> As the length of field ifr_name of struct ifreq is IFNAMSIZ(16) in header file /usr/include/net/if.h. 
> It will result in buffer overflow when devname is too long. Modified strcpy to strncpy for only 
> copying IFNAMSIZ bytes into struct ifreq. Also, by adding a section into parse_cmdline to detect 
> if the length of devname is invalid.
> 
> Signed-off-by: Zhao Yu Wang <[email-masked]>

There's already a patch checked into ethtool.git for this...

	Jeff