From: Jeff Garzik <jeff@garzik•org>
To: Dirk@Opfer-Online•de
Cc: netdev@vger•kernel.org, Ben Dooks <ben@simtec•co.uk>,
Sascha Hauer <s.hauer@pengutronix•de>
Subject: Re: [PATCH] Fix dm9000 release_resource
Date: Wed, 06 Sep 2006 10:58:44 -0400 [thread overview]
Message-ID: <44FEE224.7030904@garzik.org> (raw)
In-Reply-To: <0ML25U-1GIK892FsT-0007pS@mrelayeu.kundenserver.de>
Dirk Opfer wrote:
> dm9000_release_board calls release_resource with the platform resource
> instead of the requested resource:
>
> db->addr_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> db->addr_req = request_mem_region(db->addr_res->start, i, pdev->name);
>
> dm9000_release_board:
>
> if (db->addr_res != NULL) {
> release_resource(db->addr_res);
> kfree(db->addr_req);
>
> With this behavior the kernel will crash on the second removal. The
> attached patch fix this problem.
>
>
> Signed-off-by: Dirk Opfer <Dirk@Opfer-Online•de>
Your patch is attached base64-encoded, which makes it impossible to
comment on it inline.
Jeff
next prev parent reply other threads:[~2006-09-06 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-30 7:04 [PATCH] Fix dm9000 release_resource Dirk Opfer
2006-08-31 9:39 ` Ben Dooks
2006-09-06 14:58 ` Jeff Garzik [this message]
2006-09-06 17:53 ` Dirk Opfer
2006-09-11 13:08 ` Jeff Garzik
[not found] <0ML25U-1GIK8C13Mq-0007lB@mrelayeu.kundenserver.de>
2006-08-31 7:32 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44FEE224.7030904@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=Dirk@Opfer-Online$(echo .)de \
--cc=ben@simtec$(echo .)co.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=s.hauer@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox