Subject: Re: [PATCH 2/9] s390: netiucv driver fixes

From: Jeff Garzik <[email-masked]>
Date: Wed, 06 Sep 2006 11:13:56 -0400

[email-masked] wrote:
> [PATCH 2/9] s390: netiucv driver fixes
> 
> From: Frank Pavlic <[email-masked]>
>  - missing lock initialization added
>         - avoid duplicate iucv-interfaces to the same peer
>         - rw-lock added for manipulating the list of
>           defined iucv connections
> 
> Signed-off-by: Frank Pavlic <[email-masked]>
> ---
> 
>  drivers/s390/net/netiucv.c |   80 
> +++++++++++++++++++++++++++++++++++---------
>  1 files changed, 64 insertions(+), 16 deletions(-)
> 
> 05eebe4adf2ad6b442b3dc0bd34ccc5863299efb
> diff --git a/drivers/s390/net/netiucv.c b/drivers/s390/net/netiucv.c
> index 5d6e6cb..d7d1cc0 100644
> --- a/drivers/s390/net/netiucv.c
> +++ b/drivers/s390/net/netiucv.c
> @@ -112,7 +112,12 @@ struct iucv_connection {
>  /**
>   * Linked list of all connection structs.
>   */
> -static struct iucv_connection *iucv_connections;
> +struct iucv_connection_struct {
> + struct iucv_connection *iucv_connections;
> + rwlock_t iucv_rwlock;
> +};

Please submit a patch very soon that runs scripts/Lindent over all the 
s390 net drivers.  These drivers don't comply with 
Documentation/CodingStyle.

	Jeff