Subject: Re: [PATCH] pcnet32: Magic number cleanup

From: Jeff Garzik <[email-masked]>
Date: Tue, 12 Sep 2006 11:59:12 -0400

Don Fry wrote:
> @@ -2701,13 +2701,10 @@ static struct net_device_stats *pcnet32_
>  {
>  	struct pcnet32_private *lp = dev->priv;
>  	unsigned long ioaddr = dev->base_addr;
> -	u16 saved_addr;
>  	unsigned long flags;
>  
>  	spin_lock_irqsave(&lp->lock, flags);
> -	saved_addr = lp->a.read_rap(ioaddr);
>  	lp->stats.rx_missed_errors = lp->a.read_csr(ioaddr, 112);
> -	lp->a.write_rap(ioaddr, saved_addr);
>  	spin_unlock_irqrestore(&lp->lock, flags);

This should be in a separate patch.  Even though it is mentioned in the 
patch description, this change is totally out of character when looking 
at the rest of the patch.

	Jeff