Subject: Re: [PATCHv3 3/4][RFC] net: basic xfrm/netfilter support for UDP-Lite

From: Patrick McHardy <[email-masked]>
Date: Tue, 19 Sep 2006 09:37:08 +0200

Gerrit Renker wrote:
> Basic xfrm and netfilter support for UDP-Lite:
>   * matching of UDP-Lite packets
>   * LOG support
>   * header file support
> 
> --
> --- a/net/netfilter/xt_multiport.c
> +++ b/net/netfilter/xt_multiport.c
> @@ -161,8 +161,9 @@ check(u_int16_t proto,
>        u_int8_t count)
>  {
>  	/* Must specify supported protocol, no unknown flags or bad count */
> -	return (proto == IPPROTO_TCP || proto == IPPROTO_UDP
> -		|| proto == IPPROTO_SCTP || proto == IPPROTO_DCCP)
> +	return ( proto == IPPROTO_TCP  ||
> +		 proto == IPPROTO_UDP  || proto == IPPROTO_UDPLITE ||
> +		 proto == IPPROTO_SCTP || proto == IPPROTO_DCCP      )
>  		&& !(ip_invflags & XT_INV_PROTO)
>  		&& (match_flags == XT_MULTIPORT_SOURCE
>  		    || match_flags == XT_MULTIPORT_DESTINATION

The patch looks good besides the fancy formating above. I'm not too
much of a fan of the existing formating, but please keep it consistent.