Subject: Re: [PATCH 08/23] e1000: add multicast stats counters

From: Jeff Garzik <[email-masked]>
Date: Tue, 19 Sep 2006 15:28:18 -0400

Kok, Auke wrote:
> Signed-off-by: Mitch Williams <[email-masked]>
> Signed-off-by: Auke Kok <[email-masked]>
> ---
> 
>  drivers/net/e1000/e1000_ethtool.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000/e1000_ethtool.c
> index a954746..0d329d6 100644
> --- a/drivers/net/e1000/e1000_ethtool.c
> +++ b/drivers/net/e1000/e1000_ethtool.c
> @@ -60,6 +60,10 @@ static const struct e1000_stats e1000_gs
>  	{ "tx_packets", E1000_STAT(net_stats.tx_packets) },
>  	{ "rx_bytes", E1000_STAT(net_stats.rx_bytes) },
>  	{ "tx_bytes", E1000_STAT(net_stats.tx_bytes) },
> +	{ "rx_broadcast", E1000_STAT(stats.bprc) },
> +	{ "tx_broadcast", E1000_STAT(stats.bptc) },
> +	{ "rx_multicast", E1000_STAT(stats.mprc) },
> +	{ "tx_multicast", E1000_STAT(stats.mptc) },
>  	{ "rx_errors", E1000_STAT(net_stats.rx_errors) },
>  	{ "tx_errors", E1000_STAT(net_stats.tx_errors) },
>  	{ "tx_dropped", E1000_STAT(net_stats.tx_dropped) },

NAK -- you also need to remove the standard net stats, which are 
exported elsewhere