Subject: Re: [PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures.

From: Jeff Garzik <[email-masked]>
Date: Tue, 19 Sep 2006 17:40:34 -0400

Dave Jones wrote:
> On Tue, Sep 19, 2006 at 10:28:38AM -0700, Kok, Auke wrote:
>  > 
>  > Refine cb cleaning debug printout and print out all cleaned cbs' status. Add
>  > debug flag for EEPROM csum failures that were overridden by the user.
>  > 
>  > Signed-off-by: Jesse Brandeburg <[email-masked]>
>  > Signed-off-by: Auke Kok <[email-masked]>
>  > ---
>  > 
>  >  drivers/net/e100.c |    9 ++++++---
>  >  1 files changed, 6 insertions(+), 3 deletions(-)
>  > 
>  > diff --git a/drivers/net/e100.c b/drivers/net/e100.c
>  > index ab0868c..ae93c62 100644
>  > --- a/drivers/net/e100.c
>  > +++ b/drivers/net/e100.c
>  > @@ -761,6 +761,8 @@ static int e100_eeprom_load(struct nic *
>  >  		DPRINTK(PROBE, ERR, "EEPROM corrupted\n");
>  >  		if (!eeprom_bad_csum_allow)
>  >  			return -EAGAIN;
>  > +		else
>  > +			add_taint(TAINT_MACHINE_CHECK);
> 
> I object to this flag being abused this way.
> A corrupt EEPROM on a network card has _nothing_ to do with
> a CPU machine check exception.

Fair enough.  Better suggestions?

I think it's fair to set _some_ taint flag, perhaps a new one, on a 
known corrupted firmware.  But if others disagree, I'll follow the 
consensus here.

	Jeff, not having a strong opinion in this case