Subject: Re: [patch 3/4] Make sure ip_vs_ftp ports are valid

From: Patrick McHardy <[email-masked]>
Date: Wed, 20 Sep 2006 12:29:45 +0200

Horms wrote:
> Here is the revised patch.
> 
>
> [IPVS] Make sure ip_vs_ftp ports are valid
>
> I'm not entirely sure what happens in the case of a valid port,
> at best it'll be silently ignored. This patch ensures that
> the port values are unsigned short values, and thus always valid.
>
> Cc: Patrick McHardy <[email-masked]>
> Signed-Off-By: Simon Horman <[email-masked]>
>
> Index: linux-2.6/net/ipv4/ipvs/ip_vs_ftp.c
> ===================================================================
> --- linux-2.6.orig/net/ipv4/ipvs/ip_vs_ftp.c	2006-09-04
10:47:09.000000000 +0900
> +++ linux-2.6/net/ipv4/ipvs/ip_vs_ftp.c	2006-09-04 10:59:30.000000000
+0900
> @@ -44,8 +44,8 @@
>   * List of ports (up to IP_VS_APP_MAX_PORTS) to be handled by helper
>   * First port is set to the default port.
>   */
> -static int ports[IP_VS_APP_MAX_PORTS] = {21, 0};
> -module_param_array(ports, int, NULL, 0);
> +static unsigned short ports[IP_VS_APP_MAX_PORTS] = {21, 0};
> +module_param_array(ports, ushort, NULL, 0);
>  MODULE_PARM_DESC(ports, "Ports to monitor for FTP control commands");
>
>  /*

It looks like the wrong patch went in:

http://marc.theaimsgroup.com/?l=git-commits-head&m=115862407021941&w=2