From: "Keller, Jacob E" <jacob.e.keller@intel•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: Ido Schimmel <idosch@idosch•org>, Andrew Lunn <andrew@lunn•ch>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"davem@davemloft•net" <davem@davemloft•net>,
"mkubecek@suse•cz" <mkubecek@suse•cz>,
"pali@kernel•org" <pali@kernel•org>,
"vadimp@nvidia•com" <vadimp@nvidia•com>,
"mlxsw@nvidia•com" <mlxsw@nvidia•com>,
Ido Schimmel <idosch@nvidia•com>
Subject: Re: [RFC PATCH net-next 1/8] ethtool: Add ability to control transceiver modules' low power mode
Date: Tue, 10 Aug 2021 22:18:12 +0000 [thread overview]
Message-ID: <4512fede-0581-34fc-e609-dc986c468daa@intel.com> (raw)
In-Reply-To: <20210810150636.26c17a8c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 8/10/2021 3:06 PM, Jakub Kicinski wrote:
> On Tue, 10 Aug 2021 22:00:51 +0000 Keller, Jacob E wrote:
>>>> Jake do you know what the use cases for Intel are? Are they SFP, MAC,
>>>> or NC-SI related?
>>>
>>> I went through all the Intel drivers that implement these operations and
>>> I believe you are talking about these commits:
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c3880bd159d431d06b687b0b5ab22e24e6ef0070
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d5ec9e2ce41ac198de2ee18e0e529b7ebbc67408
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ab4ab73fc1ec6dec548fa36c5e383ef5faa7b4c1
>>>
>>> There isn't too much information about the motivation, but maybe it has
>>> something to do with multi-host controllers where you want to prevent
>>> one host from taking the physical link down for all the other hosts
>>> sharing it? I remember such issues with mlx5.
>>>
>>
>> Ok, I found some more information here. The primary motivation of the
>> changes in the i40e and ice drivers is from customer requests asking to
>> have the link go down when the port is administratively disabled. This
>> is because if the link is down then the switch on the other side will
>> see the port not having link and will stop trying to send traffic to it.
>>
>> As far as I can tell, the reason its a flag is because some users wanted
>> the behavior the other way.
>>
>> I'm not sure it's really related to the behavior here.
>>
>> For what it's worth, I'm in favor of containing things like this into
>> ethtool as well.
>
> I think the question was the inverse - why not always shut down the
> port if the interface is brought down?
>
That... is a better question yes. Unfortunately so far I haven't found
any argument for not doing this. Only a bit about many requests to have
this behavior. It might just be inertia to maintain current behavior by
default...
next prev parent reply other threads:[~2021-08-10 22:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 10:21 [RFC PATCH net-next 0/8] ethtool: Add ability to control transceiver modules Ido Schimmel
2021-08-09 10:21 ` [RFC PATCH net-next 1/8] ethtool: Add ability to control transceiver modules' low power mode Ido Schimmel
2021-08-09 14:28 ` Andrew Lunn
2021-08-10 7:26 ` Ido Schimmel
2021-08-10 13:52 ` Andrew Lunn
2021-08-10 13:59 ` Jakub Kicinski
2021-08-10 20:46 ` Ido Schimmel
2021-08-10 22:00 ` Keller, Jacob E
2021-08-10 22:06 ` Jakub Kicinski
2021-08-10 22:18 ` Keller, Jacob E [this message]
2021-08-10 22:24 ` Keller, Jacob E
2021-08-10 22:31 ` Andrew Lunn
2021-08-11 0:38 ` Keller, Jacob E
2021-08-10 22:05 ` Jakub Kicinski
2021-08-10 22:51 ` Andrew Lunn
2021-08-11 11:33 ` Ido Schimmel
2021-08-11 13:03 ` Jakub Kicinski
2021-08-11 14:36 ` Andrew Lunn
2021-08-11 19:37 ` Ido Schimmel
2021-08-11 20:30 ` Jakub Kicinski
2021-08-11 20:57 ` Andrew Lunn
2021-08-11 21:04 ` Ido Schimmel
2021-08-11 20:42 ` Andrew Lunn
2021-08-10 21:38 ` Keller, Jacob E
2021-08-09 10:21 ` [RFC PATCH net-next 2/8] ethtool: Add ability to reset transceiver modules Ido Schimmel
2021-08-09 19:13 ` Andrew Lunn
2021-08-10 13:05 ` Ido Schimmel
2021-08-10 13:54 ` Jakub Kicinski
2021-08-10 18:15 ` Ido Schimmel
2021-08-10 18:58 ` Andrew Lunn
2021-08-10 19:00 ` Jakub Kicinski
2021-08-10 19:28 ` Andrew Lunn
2021-08-10 20:50 ` Ido Schimmel
2021-08-09 10:21 ` [RFC PATCH net-next 3/8] mlxsw: reg: Add fields to PMAOS register Ido Schimmel
2021-08-09 10:21 ` [RFC PATCH net-next 4/8] mlxsw: Make PMAOS pack function more generic Ido Schimmel
2021-08-09 10:21 ` [RFC PATCH net-next 5/8] mlxsw: reg: Add Port Module Memory Map Properties register Ido Schimmel
2021-08-09 10:21 ` [RFC PATCH net-next 6/8] mlxsw: reg: Add Management Cable IO and Notifications register Ido Schimmel
2021-08-09 10:21 ` [RFC PATCH net-next 7/8] mlxsw: Add ability to control transceiver modules' low power mode Ido Schimmel
2021-08-09 10:21 ` [RFC PATCH net-next 8/8] mlxsw: Add ability to reset transceiver modules Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4512fede-0581-34fc-e609-dc986c468daa@intel.com \
--to=jacob.e.keller@intel$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=idosch@idosch$(echo .)org \
--cc=idosch@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=mkubecek@suse$(echo .)cz \
--cc=mlxsw@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pali@kernel$(echo .)org \
--cc=vadimp@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox