Subject: Re: [PATCH 6/7] [DCCP]: Fix setting of packet size in CCID3

From: Eddie Kohler <[email-masked]>
Date: Fri, 22 Sep 2006 09:57:57 -0700

> |  +	case DCCP_SOCKOPT_TX_PACKET_SIZE:
> |  +		if (dmsk->dccpms_tx_ccid != DCCPC_CCID3)
> |  +			err = -EINVAL;
> This is unfortunate: it is in the generic dccp code but
> works only for CCID 3. Same for DCCP_SOCKOPT_RX_PACKET_SIZE.

I agree with Gerrit.  An average packet size congestion control parameter 
might be useful for multiple CCIDs, even if only some CCIDs would use it. 
Would prefer that this sets the parameter in all cases.

E

> 
> 
> --Gerrit
> -
> To unsubscribe from this list: send the line "unsubscribe dccp" in
> the body of a message to [email-masked]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html