Subject: Re: [patch 11/11] forcedeth: hardirq lockdep warning

From: Jeff Garzik <[email-masked]>
Date: Mon, 25 Sep 2006 20:03:25 -0400

[email-masked] wrote:
> From: Peter Zijlstra <[email-masked]>
> 
> BUG: warning at kernel/lockdep.c:1816/trace_hardirqs_on() (Not tainted)
> 
> Call Trace:
>  show_trace
>  dump_stack
>  trace_hardirqs_on
>  :forcedeth:nv_nic_irq_other
>  handle_IRQ_event
>  __do_IRQ
>  do_IRQ
>  ret_from_intr
> DWARF2 barf
>  default_idle
>  cpu_idle
>  rest_init
>  start_kernel
>  _sinittext
> 
> These 3 functions nv_nic_irq_tx(), nv_nic_irq_rx() and nv_nic_irq_other()
> are reachable from IRQ context and process context. Make use of the
> irq-save/restore spinlock variant.
> 
> Signed-off-by: Peter Zijlstra <[email-masked]>
> Cc: Jeff Garzik <[email-masked]>
> Cc: Ingo Molnar <[email-masked]>
> Cc: Arjan van de Ven <[email-masked]>
> Cc: Dave Jones <[email-masked]>
> Cc: Ayaz Abdulla <[email-masked]>
> Signed-off-by: Andrew Morton <[email-masked]>

ACK + HOLD, must analyze locking before applying.  It still looks 
strange, even after this patch.