Subject: Re: [patch 01/11] e1000: memory leak in e1000_set_ringparam()

From: Auke Kok <[email-masked]>
Date: Mon, 25 Sep 2006 21:57:50 -0700

Jeff Garzik wrote:
> [email-masked] wrote:
>> From: Vasily Averin <[email-masked]>
>>
>> Memory leak was found in 2.6.18-rc4 and e1000 7.2.7 from sourceforge:
>> Memory allocated for new tx_ring and rx_ring leaks if
>> e1000_setup_XX_resources() fails.c Also this patch reduces stack usage
>> (removed tx_new and rx_new) and uses kzalloc instead kmalloc+memset(0)
>>
>> Signed-off-by: Vasily Averin <[email-masked]>
>> Cc: Jeb Cramer <[email-masked]>
>> Cc: John Ronciak <[email-masked]>
>> Cc: Jesse Brandeburg <[email-masked]>
>> Cc: Jeff Kirsher <[email-masked]>
>> Cc: Auke Kok <[email-masked]>
>> Cc: Jeff Garzik <[email-masked]>
>> Signed-off-by: Andrew Morton <[email-masked]>
> 
> ACK + HOLD, waiting to see if this will be included in Auke's push

Ack, I've stacked it on the workqueue and it will go out to Jeff this week.

Cheers,

Auke