Subject: Re: [PATCH 5/9][TG3]: Add tg3_poll_fw().

From: Jeff Garzik <[email-masked]>
Date: Wed, 27 Sep 2006 16:47:02 -0400

Michael Chan wrote:
> +	/* Chip might not be fitted with firmware.  Some Sun onboard
> +	 * parts are configured like that.  So don't signal the timeout
> +	 * of the above loop as an error, but do report the lack of
> +	 * running firmware once.
> +	 */
> +	if (i >= 100000 &&
> +	    !(tp->tg3_flags2 & TG3_FLG2_NO_FWARE_REPORTED)) {
> +		tp->tg3_flags2 |= TG3_FLG2_NO_FWARE_REPORTED;
> +
> +		printk(KERN_INFO PFX "%s: No firmware running.\n",
> +		       tp->dev->name);
> +	}
> +
> +	return 0;

You need to actually return failure, for the failure case.

Currently, this function is written to return an error code, but always 
returns zero.

	Jeff