Subject: Re: [PATCH 2/2] loopback: minor statistics optimization

From: Stephen Hemminger <[email-masked]>
Date: Wed, 27 Sep 2006 20:13:14 -0700

David Miller wrote:
> From: Stephen Hemminger <[email-masked]>
> Date: Fri, 8 Sep 2006 11:20:56 -0700
>
>   
>> Minor loopback enhancements for 2.6.19
>>
>> The loopback device status structure is a singleton and doesn't
>> need to be allocated. Add ethtool_ops hooks to show checksum always on,
>> and make ethtool_ops const.
>>
>> Signed-off-by: Stephen Hemminger <[email-masked]>
>>     
>
> The ethtool bits are OK, but putting the loopback stats into
> the image adds nearly 200 bytes of .data section space on
> 64-bit.
>
> I don't really think it's that big of a deal to avoid the
> kmalloc() call.
>   
Yeah but doing the kmalloc is going to get a bigger chunk (rounded up),
anyway. The statistics should show up in BSS so it won't add to kernel size.