From: Jeff Garzik <jeff@garzik•org>
To: Jouni Malinen <jkm@devicescape•com>
Cc: "John W. Linville" <linville@tuxdriver•com>,
Jean Tourrilhes <jt@hpl•hp.com>, Andrew Morton <akpm@osdl•org>,
netdev@vger•kernel.org
Subject: Re: Request to postpone WE-21
Date: Thu, 05 Oct 2006 18:37:00 -0400 [thread overview]
Message-ID: <4525890C.6060700@garzik.org> (raw)
In-Reply-To: <20061005215751.GI17517@instant802.com>
Jouni Malinen wrote:
> This looks somewhat confusing.. WE-20 (and older) included '\0' in both
> the data value and length (well, at least in most drivers and user space
> tools, if I remember correctly), i.e., essid[iwr->u.data.length] would
> be pointing one byte after the '\0' termination.. And since '\0' is
> valid character in SSID (it is just an arbitrary array of octets) it can
> also be the last octet of the SSID and WE-21 style case could have
> essid[iwr->u.data.length - 1] == '\0'..
Remember, the salient point is ensuring that WE<=20 continues to work as
expecting, without any modification. If that means a compromise in
supported SSID values, so be it. Just like older versions of stat(2)
syscall, you are stuck with the old interface, warts included.
But if we can support both styles... great! I'm all for it. Just
noting priorities. Warts and limitations are inevitable with older
interfaces.
Jeff
next prev parent reply other threads:[~2006-10-05 22:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 16:31 Request to postpone WE-21 Jean Tourrilhes
2006-10-05 20:49 ` John W. Linville
2006-10-05 21:21 ` Jean Tourrilhes
2006-10-05 21:57 ` Jouni Malinen
2006-10-05 22:07 ` Jean Tourrilhes
2006-10-05 22:37 ` Jeff Garzik [this message]
2006-10-05 22:12 ` Jean Tourrilhes
2006-10-05 22:15 ` Jouni Malinen
2006-10-05 22:20 ` Jean Tourrilhes
2006-10-10 19:40 ` John W. Linville
2006-10-10 20:28 ` Jean Tourrilhes
2006-10-19 21:56 ` Please pull 'we21-fix' branch of wireless-2.6.git John W. Linville
2006-10-19 22:10 ` Jean Tourrilhes
2006-10-21 18:12 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4525890C.6060700@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=akpm@osdl$(echo .)org \
--cc=jkm@devicescape$(echo .)com \
--cc=jt@hpl$(echo .)hp.com \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox