Subject: Re: [e1000]: flow control on by default - good idea really?

From: Auke Kok <[email-masked]>
Date: Mon, 16 Oct 2006 11:55:16 -0700

jamal wrote:
> On Thu, 2006-06-07 at 23:59 -0700, David Miller wrote:
> 
>> It's autonegotiated, check you kernel message logs when the link
>> came up, you'll see this:
>>
>> tg3: eth0: Flow control is on for TX and on for RX.
>>
> 
> yikes - yes, this would be it.
> 
> I  could be wrong and i will double check:
> I think when the e1000 says via ethtool "rx is on" - it means that it 
> is _advertising_ flow control as opposed to detecting partner has flow
> control capability.
> Auke, can you also check this as well?

Just found this in my todo box - a bit late :(

yes, that appears to be the correct interpretation: we never read back the detected FC 
state from the hardware.

Auke