Subject: Re: [PATCH] atm: fix horizon init section usage

From: "Randy.Dunlap" <[email-masked]>
Date: Mon, 23 Oct 2006 09:31:50 -0700

David Miller wrote:
> From: "Randy.Dunlap" <[email-masked]>
> Date: Sun, 22 Oct 2006 21:32:20 -0700
> 
>> David Miller wrote:
>>> From: Randy Dunlap <[email-masked]>
>>> Date: Sun, 22 Oct 2006 19:13:09 -0700
>>>
>>>> From: Randy Dunlap <[email-masked]>
>>>>
>>>> hrz_init() is called from the probe function, which is __devinit
>>>> and could be called after init.
>>>>
>>>> WARNING: drivers/atm/horizon.o - Section mismatch: reference to .init.text:.hrz_init from .text between '.hrz_probe' (at offset 0x4054) and '.hrz_remove_one'
>>>>
>>>> Signed-off-by: Randy Dunlap <[email-masked]>
>>> It is only called from hrz_init() and thus shouldn't it be
>>> thus marked __devinit as well?  That seems to be the right
>>> way to fix this one.
>> Oops, I agree.  Want me to send another patch?
> 
> No need, I'll take care of it, thanks Randy.

David,

FYI:  read_bia() also needs to be changed from __init to __devinit
since it's called from hrz_init().

-- 
~Randy