Subject: Re: [NET_SCHED 06/06]: Fix endless loops (part 4): HTB

From: Patrick McHardy <[email-masked]>
Date: Thu, 23 Nov 2006 09:44:04 +0100

Jarek Poplawski wrote:
>>+static void htb_qlen_notify(struct Qdisc *sch, unsigned long arg)
>>+{
>>+	struct htb_class *cl = (struct htb_class *)arg;
>>+
>>+	if (cl->un.leaf.q->q.qlen == 0)
> 
> 
> Probably "if (cl->prio_activity)" is needed here.

No, the function is only called for active leaf classes, which
always have prio_activity != 0.

> PS: from 00/06:
> 
>>PS: If anyone wants to suggest a nicer name for qdisc_tree_decrease_qlen
>>I'll gladly send new patches :)
> 
> 
> Increasing is nicer so maybe: qdisc_tree_increase_qlen?

But we're decreasing not increasing the qlen, so that doesn't seem
like a good choice :)