From: Patrick McHardy <kaber@trash•net>
To: Jarek Poplawski <jarkao2@o2•pl>
Cc: devik@cdi•cz, netdev@vger•kernel.org
Subject: Re: [NET_SCHED 04/06]: Fix endless loops (part 2): "simple" qdiscs
Date: Fri, 24 Nov 2006 14:07:08 +0100 [thread overview]
Message-ID: <4566EE7C.4090801@trash.net> (raw)
In-Reply-To: <20061124123350.GA1599@ff.dom.local>
Jarek Poplawski wrote:
>>diff --git a/net/sched/sch_cbq.c b/net/sched/sch_cbq.c
>>index 908b10d..ba82dfa 100644
>>--- a/net/sched/sch_cbq.c
>>+++ b/net/sched/sch_cbq.c
>>@@ -1687,7 +1687,7 @@ #endif
>> sch_tree_lock(sch);
>> *old = cl->q;
>> cl->q = new;
>>- sch->q.qlen -= (*old)->q.qlen;
>>+ qdisc_tree_decrease_qlen(*old, (*old)->q.qlen);
>> qdisc_reset(*old);
>> sch_tree_unlock(sch);
>>
>
>
> Hello,
>
> Probably it is as usual something with my eyes but
> it seems cbq needs in cbq_delete or cbq_destroy_class
> some treatment (about qdisc_destroy) similar to htb.
No, you're right about this one, CBQ needs a few further fixes:
- deactivating of active classes when grafting
- purging of queue/q.qlen adjustment when deleting an active class
- deactivating of active classes when q.qlen drops to zero in ->drop()
- purging of queue and deactivating of active leaf classes
when attaching a new child (presuming CBQ can only carry
packets in leaf classes, I'm not sure about this)
and something HTB should do is to turn intermediate classes
into leaves again when their last child is deleted.
Are you interested in fixing this? :)
next prev parent reply other threads:[~2006-11-24 13:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-20 13:08 [NET_SCHED 00/06]: Fix endless dequeue loops Patrick McHardy
2006-11-20 13:08 ` [NET_SCHED 01/06]: sch_htb: perform qlen adjustment immediately in ->delete Patrick McHardy
2006-11-30 1:35 ` David Miller
2006-11-20 13:08 ` [NET_SCHED 02/06]: Set parent classid in default qdiscs Patrick McHardy
2006-11-30 1:35 ` David Miller
2006-11-20 13:08 ` [NET_SCHED 03/06]: Fix endless loops caused by inaccurate qlen counters (part 1) Patrick McHardy
2006-11-20 14:23 ` Mika Penttilä
2006-11-20 14:31 ` Patrick McHardy
2006-11-20 14:44 ` Mika Penttilä
2006-11-20 14:51 ` Patrick McHardy
2006-11-20 16:07 ` Mika Penttilä
2006-11-20 16:42 ` Patrick McHardy
2006-11-30 1:35 ` David Miller
2006-11-20 13:08 ` [NET_SCHED 04/06]: Fix endless loops (part 2): "simple" qdiscs Patrick McHardy
2006-11-24 12:33 ` Jarek Poplawski
2006-11-24 13:07 ` Patrick McHardy [this message]
2006-11-24 13:37 ` Jarek Poplawski
2006-11-27 6:46 ` Jarek Poplawski
2006-11-30 1:36 ` David Miller
2006-11-20 13:08 ` [NET_SCHED 05/06]: Fix endless loops (part 3): HFSC Patrick McHardy
2006-11-30 1:36 ` David Miller
2006-11-20 13:08 ` [NET_SCHED 06/06]: Fix endless loops (part 4): HTB Patrick McHardy
2006-11-20 13:39 ` Martin Devera
2006-11-23 8:39 ` Jarek Poplawski
2006-11-23 8:44 ` Patrick McHardy
2006-11-23 9:01 ` Jarek Poplawski
2006-11-23 9:07 ` Patrick McHardy
2006-11-23 9:32 ` Martin Devera
2006-11-23 9:48 ` Patrick McHardy
2006-11-23 10:59 ` Jarek Poplawski
2006-11-30 1:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4566EE7C.4090801@trash.net \
--to=kaber@trash$(echo .)net \
--cc=devik@cdi$(echo .)cz \
--cc=jarkao2@o2$(echo .)pl \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox