Subject: Re: [PATCH] softmac: remove netif_tx_disable when scanning

From: Daniel Drake <[email-masked]>
Date: Sun, 26 Nov 2006 23:13:25 -0500

Johannes Berg wrote:
> On Sun, 2006-11-26 at 13:25 -0500, Daniel Drake wrote:
> 
>> No, we could stick with our existing setup if the stack did something 
>> different.
> 
> But you do need full refcounting I guess.

No, I don't think we would need to move away from our existing method:

   spin_lock_irqsave(&mac->lock, flags);
   if (mac->updating_rts_rate == 0 && mac->updating_basic_rates == 0)
     netif_wake_queue(mac->netdev);
   spin_unlock_irqrestore(&mac->lock, flags);

That said, it is in some ways comparable to refcounting without a 
counter: if both flags are set to 0, the above code is guaranteed to be 
executed twice (each time after one flag is toggled)

Daniel