Subject: Re: [PATCH] r8169: Fix iteration variable sign

From: Jeff Garzik <[email-masked]>
Date: Thu, 30 Nov 2006 06:20:39 -0500

Francois Romieu wrote:
> This changes the type of variable "i" in rtl8169_init_one()
> from "unsigned int" to "int". "i" is checked for < 0 later,
> which can never happen for "unsigned". This results in broken
> error handling.
>     
> Signed-off-by: Michael Buesch <[email-masked]>
> Signed-off-by: Francois Romieu <[email-masked]>

ACK but doesn't seem to apply to 2.6.19?

should this go into #upstream rather than #upstream-fixes?